Error check number of characteristics #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it just blindly writes beyond the end of the array, leading to impossible-to-find bugs. It doesn't help that the limit on the number of characteristics doesn't seem to be documented anywhere.
|
Automatic CI verification build not done, please verify manually. |
|
thanks for contributing. this is good sanity checking. I'll review this more carefully shortly. Looks good based on an initial glance. |
rgrover
pushed a commit
that referenced
this pull request
Oct 13, 2015
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it just blindly writes beyond the end of the array, leading to impossible-to-find bugs.
It doesn't help that the limit on the number of characteristics doesn't seem to be documented anywhere.
Sorry github's editor won't let me use spaces so there may be some correct indentation characters in there (i.e. tabs!). I did try.