Fix for GCC lost in SDK v8.0 update #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
where was this fixed, in mbed sources or in sources coming from nordic? |
|
It was fixed in this library. The nrf_svc.h file had it in but was not in the Nordic sources |
|
As I understand, it should be reported to them, not to override this fix again in the future. |
|
I just though I might submit it here as it was in before and no one who uses this library with mbed when they export to local compiler will be able to build. |
|
@rosterloh Yes, correct. My point was that we should report this type of bugs (along with fixing them locally) directly to the file owners. @rgrover will look at this PR |
rgrover
added a commit
that referenced
this pull request
Apr 22, 2015
Fix for GCC lost in SDK v8.0 update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix was previously in the library but was lost when porting over to new SDK