Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URIBeacon2Service.h should be called UriBeaconConfigService.h #11

Closed
schilit opened this issue Nov 29, 2014 · 3 comments
Closed

URIBeacon2Service.h should be called UriBeaconConfigService.h #11

schilit opened this issue Nov 29, 2014 · 3 comments
Assignees
@rgrover
Labels
enhancement

Comments

@schilit
Copy link
Contributor

schilit commented Nov 29, 2014

Hi @rgrover

The official name of the service is UriBeacon Configuration Service

We have an unpublished specification for UriBeacon Configuration Service V1 so that is why you are seeing V2. But for the purposes here we can keep the name simpler. Suggest UriBeaconConfigService since there may be other services, such as "telemetry" data.
@rgrover
Copy link
Contributor

rgrover commented Nov 29, 2014

Reasonable. Will change.

@rgrover rgrover self-assigned this Nov 30, 2014
@rgrover
Copy link
Contributor

rgrover commented Dec 1, 2014

This has now been fixed. Please verify and close.

@schilit
Copy link
Contributor Author

schilit commented Dec 1, 2014

Nice

@schilit schilit closed this as completed Dec 1, 2014
jacobrosenthal pushed a commit to jacobrosenthal/ble that referenced this issue Dec 24, 2017
@deadprogram
Correct ARMmbed#11 by reseting the hci device during initialization
268b629 
Signed-off-by: deadprogram <[email protected]>
jacobrosenthal pushed a commit to jacobrosenthal/ble that referenced this issue Dec 24, 2017
@roylee17
Merge pull request ARMmbed#26 from hybridgroup/bugfix/issue-11
3b91027 
Correct ARMmbed#11 by reseting the hci device during initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrover rgrover

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgrover @schilit