Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URIBeacon2Service configure() #14

Closed
schilit opened this issue Nov 29, 2014 · 2 comments
Closed

URIBeacon2Service configure() #14

schilit opened this issue Nov 29, 2014 · 2 comments
Assignees
@rgrover
Labels
bug

Comments

@schilit
Copy link
Contributor

schilit commented Nov 29, 2014

What is the purpose of public methods like URIBeacon2Service ::setFlags

These call configure() but do not call ble.setAdvertisingPayload()

These methods do not call ble.updateCharacteristicValue so the values are never reflected in GATT.

Also configure() is called twice in onDataWritten for reset.
@rgrover
Copy link
Contributor

rgrover commented Nov 29, 2014

right on these. thanks. will fix.

@rgrover rgrover self-assigned this Nov 30, 2014
@rgrover rgrover added the bug label Nov 30, 2014
@rgrover
Copy link
Contributor

rgrover commented Dec 1, 2014

This has now been fixed. Please verify and close.

@schilit schilit closed this as completed Dec 1, 2014
jacobrosenthal pushed a commit to jacobrosenthal/ble that referenced this issue Dec 24, 2017
gatt: add ble.Client.Disconnected() <-chan struct{}
0df5af5 
Since we've turned most of the GATT level API synchronous, the only
asynchronous event is disconnected by remote peripheral, or the signal
breaks up.

  // Disconnected returns a channel, which is closed when the client
  // disconnects.
  ble.Client.Disconnected() <-chan struct {}

issue ARMmbed#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrover rgrover

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgrover @schilit