Remove persistant callbacks #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operator== to functionpointerWithContext class
conversion and function operator syntax to CallChainOfFunctionPointerWithContext
Provide access to Callchains
… with the continuation function
…ut it is a mechanism internal to CallChain object. This change allow to safelly remove a callback in a callchain while calling it. It also clean responsabilities and reduce coupling.
| * | ||
| * @oaram toDetach FunctionPointerWithContext to detach from this callchain | ||
| * | ||
| * @return true if a function pointer has been detached and false otherwise |
There was a problem hiding this comment.
it would be nice to return true if detach was successful. currently the doc-header doesn't match the function.
There was a problem hiding this comment.
Oups sorry about this, I will fix it right away
| onHVXCallbackChain.add(callback); | ||
| } | ||
|
|
||
| HVXCallbackChain_t& onHVX() { |
There was a problem hiding this comment.
please add a documentation header. it might be good to add a code-example showing its use
|
looks good other than the comments made already. This is a useful contribution. |
Add SafeBool class which allow to easily declare a safe bool operator in
c++03.
CallChainOfFunctionPointerswithContext:
- unify syntax of add
- detach function now return true if a function has been detached and
false otherwise
- Explanations about function call operator
- use safe bool idiom
- explanations about iterator and why it is mutable
FunctionPointerWithContext:
- fix call propagation
- use safe bool idiom
Gap:
- add documentation
- onRadioNotification does mot call initRadioNotification anymore
GattClient:
- documentation
GattServer:
- documentation
|
this is a new feature. this pushes ble to v2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improve
CallChainOfFunctionPointersWithContext,FunctionPointerWithContextand provide a way to unregister callbacks previously registered in a callchain.Changes in
FunctionPointerWithContextare not minor, goals were to provide function pointer semantic and value semantic:nextFunctionPointerWithContext, it is not its responsibility any more. This change can be seen as a breaking one.FunctionPointerWithContextneeds to handle less things, is it a list, a node of a list, a call chain ? Unfortunately, mixing responsibilities hurt and I was forced to make this change if I wanted to make callback called only once worked.CallChainOfFunctionPointersWithContextimprovements:DiscoveredCharacteristicimprovements:Gapimprovements:GattClientimprovements:GattServerimprovements:EventCallback_tis now aFunctionPointerwithContextinstead of a plain function pointerServiceDiscoverycallbacks are FunctionPointerWithcontext instances instead of plain function pointer