Separate the concept of minlen and len in GattAttr #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous versions of BLE_API the GattCharacteristic initLen parameter is named minLen as well. When the characteristic is committed to the SoftDevice the value of initial length is also used as the minimum length of the characteristic value. Furthermore, the test (max_length == min_length) is used to determine whether the characteristic value has variable length. This is slightly confusing and also causes problems if the user wishes to use a characteristic with variable length but the initial lenght is equal to max length. To solve this problem the characteristic is now always committed to the SoftDevice as variable. Furthermore, the API only maintains the current lenght and the max length i.e. the field initialLen in the GattAttribute is removed. Finally, the constructor for the GattCharacteristic was modified to reflect these changes. *NOTES:* * This change requires updates to ble-nrf51822. * Ideally we would like the characteristics to be declared as 'variable' only when necessary, but this requires changing the signature of the GattCharacteristic and GattAttribute constructures. Therefore, it will be part of a separate pull request.
rgrover
added a commit
that referenced
this pull request
Nov 29, 2015
Separate the concept of minlen and len in GattAttr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous versions of BLE_API the GattCharacteristic initLen parameter is named minLen as well. When the characteristic is committed to the SoftDevice the value of initial length is also used as the minimum length of the characteristic value. Furthermore, the test (max_length == min_length) is used to determine whether the characteristic value has variable length. This is slightly confusing and also causes problems if the user wishes to use a characteristic with variable length but the initial length is equal to max length.
To solve this problem the characteristic is now always committed to the SoftDevice as variable. Furthermore, the API only maintains the current length and the max length i.e. the field initialLen in the GattAttribute is removed. Finally, the constructor for the GattCharacteristic was modified to reflect these changes.
NOTES: