Allow GattAttributes to have variable length #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -311,6 +311,8 @@ class GattCharacteristic { | |||
| * The length in bytes of this characteristic's value. | |||
| * @param[in] maxLen | |||
| * The max length in bytes of this characteristic's value. | |||
| * @param[in] hasVariableLen | |||
| * Whether the attribute's value length changes overtime. | |||
added 3 commits
December 2, 2015 11:26
Previously the concepts of initLength and lenth were clearly separated. However, this was at the cost of registering all characteristics in the SoftDevice as having variable length. Clearly, this is not the desired behaviour. Therefore, an additional field '_hasVariableLen' is added to the GattAttribute to address the problem. Also, the GattAttribute and GattCharacteristic constructors have been modified to take a boolean that sets '_hasVariableLen'.
The following subclasses of GattCharacteristic now have fixed length by passing false as the last parameter to the GattCharacteristic constructore: * ReadOnlyGattCharacteristic * WriteOnlyGattCharacteristic * ReadWriteGattCharacteristic * WriteOnlyArrayGattCharacteristic * ReadOnlyArrayGattCharacteristic * ReadWriteArrayGattCharacteristic
The following subclasses of GattCharacteristic are modified to have variable size: * WriteOnlyGattCharacteristic * ReadWriteGattCharacteristic * WriteOnlyArrayGattCharacteristic * ReadWriteArrayGattCharacteristic
|
@rgrover: made changes according to comments |
rgrover
added a commit
that referenced
this pull request
Dec 2, 2015
Allow GattAttributes to have variable length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the concepts of initLength and lenth were clearly separated. However, this was at the cost of registering all characteristics in the SoftDevice as having variable length. Clearly, this is not the desired behaviour. Therefore, an additional field '_hasVariableLen' is added to the GattAttribute to address the problem. Also, the GattAttribute and GattCharacteristic constructors have been modified to take a boolean that sets '_hasVariableLen'.
@rgrover