Fix documentation for advertising interval getters #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bleAdvertisingInterval
| @@ -183,14 +183,16 @@ class Gap { | |||
| } | |||
|
|
|||
| /** | |||
| * @return Minimum Advertising interval in milliseconds. | |||
| * @return Minimum Advertising interval in milliseconds for connectable | |||
| * undirected and connectable directed event types. | |||
There was a problem hiding this comment.
might be nice to include Vincent's summary:
The standard also say that for scannable undirected and non-connectable undirected, the advertising *shall not be less than 100ms`.
Plus, there is a low duty cycle and high duty cycle advertising rate for connectable directed events.
To summarize advertising interval:
• ADV_CONNECTABLE_UNDIRECTED => [20:10240]
• ADV_CONNECTABLE_DIRECTED
o low duty cycle => [20:10240]
o high duty cycle => [X:3.75]
• ADV_SCANNABLE_UNDIRECTED => [100:10240]
• ADV_NON_CONNECTABLE_UNDIRECTED => [100:10240]
There was a problem hiding this comment.
merging it for now. further improvements can be expected to follow.
rgrover
added a commit
that referenced
this pull request
Dec 4, 2015
Fix documentation for advertising interval getters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix documentation for getMinAdvertisingInterval() and getMinNonConnectableAdvertisingInterval() functions in Gap.h