Add onShutdown to register callbacks #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an onShutdown() function to Gap, GattClient, GattServer and SecurityManager. The callbacks are added to a private callback chain in each of the instances. The callbacks will be executed inside each object's reset() function BEFORE the state of the instance is cleared. The developers of the platform-specific implementation must call the parent class' reset() function for the callbacks to be executed. Finally, an onShutdown() function that returns the shutdown callchain is added to allow detaching callbacks.
|
@LiyouZhou @pan- @rgrover: This PR is related to #141 |
| @@ -161,6 +161,9 @@ class Gap { | |||
|
|
|||
| typedef FunctionPointerWithContext<bool> RadioNotificationEventCallback_t; | |||
|
|
|||
| typedef FunctionPointerWithContext<const Gap *> GapShutdownCallback_t; | |||
There was a problem hiding this comment.
I'm not sure that Gap should be const here, the user will want to remove its own callback from the shutdown callback.
There was a problem hiding this comment.
Thanks for pointing this out. Once the callback is executed it is not removed from the callback chain. In my opinion the best approach is to add code to the reset() functions in every class clearing the callback chain which would effectively reset state.
|
+1 |
|
@rgrover @LiyouZhou @pan-: I have updated the pull request to clear the shutdown callchain after the callbacks are executed. This is in response to @pan- comment about |
|
+1 |
pan-
added a commit
that referenced
this pull request
Dec 17, 2015
Add onShutdown to register callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an onShutdown() function to Gap, GattClient, GattServer and
SecurityManager. The callbacks are added to a private callback chain in each of
the instances. The callbacks will be executed inside each object's reset()
function BEFORE the state of the instance is cleared. The developers of the
platform-specific implementation must call the parent class' reset() function
for the callbacks to be executed.
Finally, an onShutdown() function that returns the shutdown callchain is added
to allow detaching callbacks.