Introduced fix for defect IOTSFW-1058 #79
Conversation
Introduced a fix for defect IOTSFW-1058 that caused the BLE_EddystoneBeaconConfigService example in ARMmbed/ble-examples repo to fail. Refer to JIRA defect for more details.
| return false; | ||
| } | ||
| defaultUrlPower = power; | ||
| memcpy(defaultUriData, encodedUrlIn, URI_DATA_MAX); |
There was a problem hiding this comment.
would strncpy() be better here? I don't like to use memcpy() because it is unconditional. It might be copying memory which isn't related to the encoded URL. This is not an issue; but just an sanity booster.
There was a problem hiding this comment.
I think this would introduce a bug. Recall that the encoding for ".com/" is 0x0, which is equivalent to "\0" then with the encoding of a URL like "http://mbed.com/hello" the last 5 characters will be dropped. This is because according to the documentation for strncpy():
If the end of the source C string (which is signaled by a null-character) is found before num characters have been copied, destination is padded with zeros until a total of num characters have been written to it.
Introduced fixes after review of previous commit with regards to JIRA defect IOTSFW-1058.
Introduced fix for defect IOTSFW-1058
Introduced a fix for defect IOTSFW-1058 that caused the
BLE_EddystoneBeaconConfigService example in ARMmbed/ble-examples repo to fail.
Refer to JIRA defect for more details.