BLE::init() now takes in a callback paramter #91
Conversation
- There's a new type: BLE::InitializationCompleteCallback_t - init() now takes a completion callback. This is an optional parameter, if no callback is setup the application can still determine the status of initialization using BLE::hasInitialized() (see below). - There's a new API: BLEInstanceBase::hasInitialized() which transports need to implement. - BLEInstanceBase.h is no longer included from BLE.h. We use a forward declaration of BLEInstanceBase instead. This is required us to move implementations of BLE methods out of the header and into BLE.cpp. - There's a new API: BLE::getInstanceID(), which simply returns the ID of an instance. - There are new error types around initialization.
|
please note that this changes the minor number. |
|
refer to #90 |
|
I would bump the major version number for something like this. Looks good though. |
|
It looks good to me but I'm worried about the default parameter in the init member function. |
|
@pan- that was actually my point with the major version change - with the version bump it wont be a silent change. |
|
@pan- I believe we will be updating all examples to reflect the new init API; so the impact to future dual-chip targets would be minimized. We'll also inform our existing target-owners. |
BLE::init() now takes in a callback paramter
============= * Update init() to match the changes around initializationCompleteCallback. Also implemented hasInitialized(). Refer to ARMmbed/ble#91 and ARMmbed/ble#90. * Some changes for memory savings. Certain singletons are now allocated dynamically; so some memory may not be needed if the application exercises limited functionality. Also reduced the size of some global tables for memory savings; affected tables/constants: UUID_TABLE_MAX_ENTRIES (down to 4), DEVICE_MANAGER_MAX_BONDS (down to 2).
============= * Update init() to match the changes around initializationCompleteCallback. Also implemented hasInitialized(). Refer to ARMmbed/ble#91 and ARMmbed/ble#90. * Some changes for memory savings. Certain singletons are now allocated dynamically; so some memory may not be needed if the application exercises limited functionality. Also reduced the size of some global tables for memory savings; affected tables/constants: UUID_TABLE_MAX_ENTRIES (down to 4), DEVICE_MANAGER_MAX_BONDS (down to 2).
There's a completion callback.
This will require corresponding change to ble-nrf51822. Demos will need to be adapted.
Please review @pan- @andresag01 @marcuschangarm @jaustin