Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files from peer manager from nRF51 SDK 10.0.0 #15

Merged
merged 3 commits into from
Jan 8, 2016

Conversation

andresag01
Copy link

Add a subset of the files from the peer manager from nRF51 SDK 10.0.0. This
code is required to implement whitelising in the ble-nrf51822 module.

@pan- @LiyouZhou

Andres Amaya Garcia added 2 commits January 7, 2016 18:55
Add a subset of the files from the peer manager from nRF51 SDK 10.0.0. This
code is required to implement whitelising in the ble-nrf51822 module.
@andresag01
Copy link
Author

NOTE: please try to build something before merging.

NOTE: Some of the files I have included are just headers and I left out the actual implementation since we actually do not require this. Would you like me to include the implementation as well for completeness?

source/nordic-sdk/components/ble/peer_manager/ble_gatt_db.h
source/nordic-sdk/components/ble/peer_manager/ble_conn_state.h
source/nordic-sdk/components/ble/peer_manager/sdk_mapped_flags.h
source/nordic-sdk/components/ble/peer_manager/peer_database.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is different, can you fix it please.

@LiyouZhou
Copy link
Contributor

Apart from the indentation, I'm happy with this. Tested ble heartrate example, it compiles fine. +1

@andresag01
Copy link
Author

@LiyouZhou I will fix the indentation and also include some extra files such as the actual implementation of the headers I already added. Even though it is not required, I think it would be good to include the implementation for completeness.

@pan-
Copy link
Member

pan- commented Jan 8, 2016

I'm fine with this PR, I will merge it when the indentation is fixed.

@andresag01
Copy link
Author

@pan- @LiyouZhou Fixed indentation. Just a note, that file is completely written using tabs rather than spaces, we should change that...

pan- added a commit that referenced this pull request Jan 8, 2016
Add files from peer manager from nRF51 SDK 10.0.0
@pan- pan- merged commit 3843844 into ARMmbed:master Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants