Expose function in DM to calculate BLE hash #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hash function is needed to generate this a new Private Resolvable address. This functionality is required to generate a table with a list of addresses from the information in the bond table (See the getAddressesFromBondTable() API in BLE API SecurityManager). However, this function is not exposed by the nRF51 SDK to external code. This pull requests simply adds the function declaration to the relevant .h file to make external use possible.
| @@ -229,6 +229,31 @@ ret_code_t im_wlist_create(pm_peer_id_t * p_peer_ids, | |||
| */ | |||
| bool im_address_resolve(ble_gap_addr_t const * p_addr, ble_gap_irk_t const * p_irk); | |||
|
|
|||
| /**@brief Function for calculating the ah() hash function described in Bluetooth core specification | |||
There was a problem hiding this comment.
Can you make a note here to say this is special modification needed in mbed. and write down the reason you need it. Make it prominent as well, enclose it in something like ==========. Next time when we make the port to a newer version (v11 is on the horizon) the porter will know to keep this modification in.
There was a problem hiding this comment.
@LiyouZhou I have just added the @note as you requested. See https://github.com/ARMmbed/nrf51-sdk/pull/17/files#diff-999146604efce71bca279e64873ab799R255.
| * | ||
| * @note ====IMPORTANT==== | ||
| * This is a special modification to the original nRF51 SDK required by the mbed BLE API | ||
| * to being able to generate BLE private resolvable addresses. This function is used by |
There was a problem hiding this comment.
Should it be "to be able to"? @iriark01
|
Yes |
|
@andresag01 Please act on the above comment. |
|
@LiyouZhou Fixed typo. |
|
+1 |
pan-
added a commit
that referenced
this pull request
Jan 11, 2016
Expose function in DM to calculate BLE hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash function is needed to generate this a new Private Resolvable address.
This functionality is required to generate a table with a list of addresses
from the information in the bond table (See the getAddressesFromBondTable() API
in BLE API SecurityManager). However, this function is not exposed by the
nRF51 SDK to external code. This pull requests simply adds the function
declaration to the relevant .h file to make external use possible.
Refer to https://github.com/ARMmbed/ble-nrf51822/pull/103/files#diff-e2ce540b25070fc6f3c585a68f7d8000R315 for and example usage in the ble-nrf51822 module.
@pan- @LiyouZhou