Optimise to omit frame pointer even in a debug build #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2016 15:42
In bootloader_util.c there is a piece of asm that uses r7. r7 is usually used by gcc as a frame pointer hence gcc would complain even though a frame pointer is not actually needed. -fomit-frame-pointer prevents this warning.
|
This seems to fix the problem. I tried building with GCC and Lets wait for @pan- to comment. |
|
It's ok for me, I merge. |
pan-
added a commit
that referenced
this pull request
Jan 20, 2016
Optimise to omit frame pointer even in a debug build
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bootloader_util.c there is a piece of asm that uses
r7. r7 is usually used by gcc as a frame pointer hence gcc
would complain even though a frame pointer is not actually
needed. -fomit-frame-pointer prevents this warning.
fixes #11
@pan- @andresag01 please review