Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manta minfix #669

Merged
merged 28 commits into from
Feb 20, 2024
Merged

Manta minfix #669

merged 28 commits into from
Feb 20, 2024

Conversation

drosofff
Copy link
Member

@drosofff drosofff commented Feb 11, 2024

Put profile as a macro
Always returns configManta.py.ini (suppress config_file_check variable) as a default dataset.
Update tests accordingly
Add Python 2 for the invocation of customConfigManta.py (otherwise the argparse module is not found)

Ed. The conda manta package is tortuous and complicated to use!

@drosofff
Copy link
Member Author

drosofff commented Feb 12, 2024

poke @bgruening

A lot of commits and action for not much... There is a non-boolean forced output now (the configfile).
Tell me if it fits your (minimal) expectations!

BTW, do you know how to get rid of these warnings in actions?

Annotations
5 warnings
Setup cache and determine changed repositories (3.11)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/cache@v3, actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@drosofff drosofff merged commit 569d223 into main Feb 20, 2024
@drosofff drosofff deleted the mantaMinfix branch February 20, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant