Added JsonSerializerSettings / JsonSerializer support #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any methods that use
JObject.FromObject
orJObject.ToObject
can now use aJsonSerializer
which is constructed from aJsonSerializationSettings
instance, allowing custom serialization rules to be applied transparently without the event store being aware.The
JsonSerializationSettings
instance is injected from theAzureDocumentDbStorageEngineBuilder
. This allows custom serialization converters (and other Json.Net extensions) to be provided to theAzureDocumentDbStorageEngine
and allows control over how the events are serialized.I tried to avoid this change by providing the
JsonSerializationSettings
instance to theDocumentClient
, but the use ofJObject.FromObject
andJObject.ToObject
used their ownJsonSerializationSettings
which ignored the converters.An alternative to this PR is to change the type of the
DocumentDbStorageEvent.Body
property to object instead of JObject which would force the DocumentClient to perform the body serialization, however, this may break existing stores due to the contract change.Some use cases for this level of event serialization