feat: preserve sha1 integrity and auto detect lockfile #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y hash when `sha1` is used due to private repositories such as Azure Artifacts not supporting anything other than `sha1`. feat: removed need for `--lockfile` flag if a `yarn.lock` or `package-lock.json` exists. Defaults to `yarn.lock` if not found. You can still specify a lockfile if you wish. chore: updated eslint-plugin-import to ^2.31.0 for eslint 9 support
asos-danielc
requested review from
asos-tomp,
asos-domhoare and
asos-israelokwuje
asos-tomp
reviewed
Nov 27, 2024
asos-tomp
reviewed
Nov 27, 2024
asos-tomp
reviewed
Nov 27, 2024
asos-tomp
reviewed
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #9
Also improves support for private NPM registries (such as Azure Artifacts) which does not support anything but sha1 integrity hashes, as well as auto detection of lockfile and additional eslint 9 dependency support.
Details
Brief summary of PR purpose and code changes.
--preserve-integrityflag to prevent removal of integrity hash whensha1is used due to private repositories such as Azure Artifacts not supporting anything other thansha1.--lockfileflag if ayarn.lockorpackage-lock.jsonexists. Defaults toyarn.lockif not found. You can still specify a lockfile if you wish.CheckList
main.