Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3] Remove hardcoded snyk path #4

Merged
merged 6 commits into from
Dec 16, 2021

Conversation

asos-craigmorten
Copy link
Contributor

@asos-craigmorten asos-craigmorten commented Dec 16, 2021

Issue

Fixes #3

Details

  • fix: don't rely on hardcoded paths to snyk binary

Update relies on user having npx installed, which will be the case since version 5.2.0 of npm - https://nodejs.dev/learn/the-npx-nodejs-package-runner

We use https://docs.npmjs.com/cli/v8/configuring-npm/package-json#engines to ensure that this condition is met.

CheckList

  • PR starts with [ISSUE_ID].
  • Has been tested (where required) before merge to main.

@asos-craigmorten asos-craigmorten self-assigned this Dec 16, 2021
@asos-craigmorten asos-craigmorten added the bug Something isn't working label Dec 16, 2021
@asos-craigmorten asos-craigmorten merged commit 4da1ea9 into main Dec 16, 2021
@asos-craigmorten asos-craigmorten deleted the fix/issue-3-remove-hardcoded-snyk-path branch December 16, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Error: spawn ... snyk ENOENT
2 participants