Checkstyle report is generating for sun_checks instead of google_checks

[ABHAY0O7]

The problem about the checkstyle that I mention in this issue #42 still exists.

See report generated:

In code too:

But this time I also got the cause for it.
In the project's pom file it is clearly mentioned that Google_checks are adopted.

See this

It is true that in the parent checkstyle module, the configuration is of google checks.
See

But the module that is configured in both depclean core and maven plugin is of sun_checks.
See this

So it can be fixed either by mentioning that sun_checks are adopted in parent pom file or replace the checkstyle with this one in both depclean core as well as in maven plugin.
I can fix this issue but please suggest to me the correct way (mentioned above) of fixing this issue.

[cesarsotovalero]

Hi @ABHAY0O7, thanks for reporting this issue.

Checkstyle is part of the DepClean CI pipeline. If you look at the pom.xml of the DepClean modules (eg. https://github.com/castor-software/depclean/blob/master/depclean-core/pom.xml#L48), you will notice that the configuration file used is the checkstyle.xml located at the root of the repo, which is actually a less strict version of the Google conventions, see https://github.com/castor-software/depclean/blob/master/checkstyle.xml.

If you run mvn checkstyle:checkstyle then the default maven-checkstyle-plugin is executed, which is configured to use the sun_checks. To run the Checkstyle configured for this project (which should trigger no errors), you should run mvn validate for if you want to run check Checkstyle goal (see https://github.com/castor-software/depclean/blob/master/depclean-core/pom.xml#L52) or mvn verify for the checkstyle goal that generates the report (see https://github.com/castor-software/depclean/blob/master/depclean-core/pom.xml#L52).

To fix the issue and get the correct report when running mvn checkstyle:checkstyle, the property <checkstyle.config.location>../checkstyle.xml</checkstyle.config.location> needs to be added in the pom.xml (see https://stackoverflow.com/a/14010915/10480869).

I've just created a PR to solve the issue, see #71.

[cesarsotovalero]

@ABHAY0O7 Please close this issue IF #71 fixed this issue. Thanks.

[ABHAY0O7]

Thanks, @cesarsotovalero,
I checked it and the issue is solved.