New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/jdk8support #44

Closed

mtorres10 wants to merge 3 commits into ASSERT-KTH:master from mtorres10:feature/jdk8support

Contributor

mtorres10 commented Mar 16, 2021

I was able to successfully build and execute a using JDK8. These are my findings:

Change your POM same as your commit.
You need to change method Path.of to Paths.get, see this link.
You need to clean any previous installation you did on your maven repo (I deleted the corresponding folder in my .m2 folder).
You need to do a mvn clean for each project in the depclean solution (not sure this is strictly required but I did it).
You need to build/compile using JDK 8 (I used adoptjdk-hotspot 282).

Marco added 2 commits

March 16, 2021 14:39


          Support for jdk8

56c4cef


          Replace Path.of with Paths.get to enable support for JDK8

2e90ba3

mtorres10 mentioned this pull request

Does not work with JDK 8 bsed project #25

Closed

cesarsotovalero approved these changes

View reviewed changes

Collaborator

cesarsotovalero commented Mar 17, 2021 •

edited

Loading

Hi @mtorres10, thanks for the analysis.
The related PR made by @amottier is more concise, see #45.
I'm closing this PR now.

Please keep contributing. Your PRs are more than welcome!


          Merge branch 'master' into feature/jdk8support

e831a0d

cesarsotovalero closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet