-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend project to run as maven plugin #898
Conversation
|
@khaes-kth I have updated the details about the new feature in the description. Do check it out. |
The tests finally work on Windows and macOS as well. 😌 Time to update the documentation. |
@khaes-kth @monperrus Please try out sorald Summary of changes
Since we are not meeting this week, I will attach demos of the respective goals. Future workA lot of work is left, but we can delegate them to later PRs.
Needless to say, the documentation has to be updated whenever deemed necessary. |
Investigate why this "error" is logged while building the maven plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR. Thanks @algomaster99
Reference: #892
This PR extends the project to be used as a maven plugin. I have added two goals to the maven plugin,
mine
andrepair
. However, only a few options are available at the moment. The main objective right now is to release a maven plugin that is used in the demo at EclipseCon 2022.Design Philosophy
Usage of new feature
Before using the plugin, you need to install the plugin locally. Follow these steps to set it up:
v3.8.6
. Therepair
command does not work on different versions.mvn install -DskipUnitTests -DskipIntegrationTests
.mine
goalRun this on any
maven
project and you should get a list of mined violations.-DhandledRules
is optional and it works exactly how it is written here.repair
goalmvn se.kth.castor:sorald:0.6.1-SNAPSHOT:repair -DruleKey=<>
The
ruleKey
parameter is required here and again, see its input here . This should also run on anymaven
project and produce repairs or does nothing if there are no violations found.ToDo
repair
goal works with3.6.3
as well because I assume this version is used by a majority of people since it is shipped byapt
package manager. Resolved inb05ece5
(#898)