Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to open images in new browser tab by MMB. #12379

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

diegocr
Copy link
Contributor

@diegocr diegocr commented Aug 6, 2023

Description

Basically, as a shortcut for context-menu -> Open Image in New Tab.

Checklist:

if (!opts.js_modal_lightbox || evt.button != 0) return;
if (!opts.js_modal_lightbox || evt.button != 0) {

if (evt.button < 2) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incidentally also covering !opts.js_modal_lightbox, or perhaps I should evt.button == 1 explicitly?

@AUTOMATIC1111
Copy link
Owner

make it an obvious if(button==1){ ...; return; } before existing code, without editing existing code.

@diegocr
Copy link
Contributor Author

diegocr commented Aug 7, 2023

Done as advised 👍🏻

@AUTOMATIC1111 AUTOMATIC1111 merged commit 251140f into AUTOMATIC1111:dev Aug 7, 2023
3 checks passed
@w-e-w w-e-w mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants