Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lora_in_memory_limit: none >int #13257

Closed
wants to merge 1 commit into from
Closed

fix: lora_in_memory_limit: none >int #13257

wants to merge 1 commit into from

Conversation

manahter
Copy link

@manahter manahter commented Sep 14, 2023

Description

  • Every time I started sdwebui, lora was not running at all because there was no variable named shared.opts.lora_in_memory_limit.
  • Before the while I put an if statement that checks the variable shared.opts.lora_in_memory_limit
  • Previously lora was not working. It works now.

Checklist:

@catboxanon
Copy link
Collaborator

I think #12957 and #13213 resolve this properly?

@manahter manahter changed the base branch from master to dev September 14, 2023 17:37
@AUTOMATIC1111
Copy link
Owner

need to re-check if this still is an issue in dev

@manahter
Copy link
Author

need to re-check if this still is an issue in dev

I don't know how to "re-check".
I can do it if you tell me.

@AUTOMATIC1111
Copy link
Owner

checkout dev branch without your PR, run it, see if the issue is still present

@manahter
Copy link
Author

checkout dev branch without your PR, run it, see if the issue is still present

Screen

I'm using Windows 11

  • I tested "dev" branch now.
  • Same issue continues.
  • There is a need for 1 line of code correction, which I implemented.

@AUTOMATIC1111
Copy link
Owner

Something seems to be wrong on your side. I can't reproduce it in my dev environemnt, and I also cloned the repo into a fresh dir, swiitched to dev, and the problem is not present still. Do you have something like "lora_in_memory_limit": null, in your config.json?

@manahter
Copy link
Author

Something seems to be wrong on your side. I can't reproduce it in my dev environemnt, and I also cloned the repo into a fresh dir, swiitched to dev, and the problem is not present still. Do you have something like "lora_in_memory_limit": null, in your config.json?

Yes, There is

@manahter manahter closed this Sep 30, 2023
@manahter manahter deleted the lora_in_memory_limit branch September 30, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants