Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested manual cast #14689

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Fix nested manual cast #14689

merged 3 commits into from
Jan 20, 2024

Conversation

KohakuBlueleaf
Copy link
Collaborator

Description

Avoid error in this situation:

with manual_cast():
  with manual_cast():
    pass

Which will be triggered by hires-fix.

Checklist:

@AUTOMATIC1111
Copy link
Owner

Wouldn't that disable it too early?

# disabled
with manual_cast():
  # enabed
  with manual_cast():
    # enabed
    pass
   # disabled  <--- should be enabled here
#disabled

@KohakuBlueleaf
Copy link
Collaborator Author

@AUTOMATIC1111 Fixed

@AUTOMATIC1111 AUTOMATIC1111 merged commit c1713bf into dev Jan 20, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the fix-nested-manual-cast branch January 20, 2024 08:43
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
Closed
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KohakuBlueleaf @AUTOMATIC1111