Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XYZ override rework #15836

Merged
merged 4 commits into from
Jun 8, 2024
Merged

XYZ override rework #15836

merged 4 commits into from
Jun 8, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented May 18, 2024

Description

changes

  • use apply_override for Clip skip
  • use override for uni_pc_order
  • use override of sd_vae
  • remove unused code

some axis is implemented using direct setting modification
but all these are not settings that are particularly special that happens in the early stages of the pipeline so override settings does work
so no reason to not switch to override is as it is more consistent as override has a higher priority
and has the benefit of simplified code as we don't need to re-implement the restoration of originating

higher priority as in for example clip, is is possible to forgot you have a override setting set in the UI that changes the clip
if you did not remove the setting then the override on the setting will have priority over the xyz axis

functionally nothing has changed aside from Automatic vae choices

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner May 18, 2024 21:02
@AUTOMATIC1111 AUTOMATIC1111 merged commit cbac72d into dev Jun 8, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the xyz-override-rework branch June 8, 2024 07:40
@lawchingman lawchingman mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants