Check if the value is a string, an iterable, or other, in that order …

…(order is important, as a string is also an iterable). Then do the replacements.

.gitignore

@@ -8,6 +8,7 @@ __pycache__/
 # Distribution / packaging
 .Python
 env/
+venv/
 build/
 develop-eggs/
 dist/

setup.py

@@ -15,7 +15,7 @@
     keywords='stackexchange',
     packages=find_packages(exclude=['contrib', 'docs', 'tests*', 'test']),
     version='0.1.12',
-    install_requires=['requests'],
+    install_requires=['requests', 'six'],
     tests_require=['mock'],
     classifiers=[
         'Development Status :: 4 - Beta',

stackapi/stackapi.py

@@ -4,6 +4,7 @@
 import datetime
 import calendar
 import requests.compat
+import six
 
 
 class StackAPIError(Exception):
@@ -148,7 +149,20 @@ def fetch(self, endpoint=None, page=1, key=None, filter='default', **kwargs):
         #   badges/222;1306;99999
         for k, value in list(kwargs.items()):
             if "{" + k + "}" in endpoint:
-                endpoint = endpoint.replace("{"+k+"}", ';'.join(requests.compat.quote_plus(str(x)) for x in value))
+                # using six for backwards compatibility
+                if isinstance(value, six.string_types):
+                    endpoint = endpoint.replace("{" + k + "}", requests.compat.quote_plus(str(value)))
+                else:
+                    # check if value is iterable, based on
+                    # https://stackoverflow.com/questions/1952464/in-python-how-do-i-determine-if-an-object-is-iterable
+                    # notice that a string is also an iterable, that's why it's checked first
+                    try:
+                        iterator = iter(value)
+                        endpoint = endpoint.replace("{" + k + "}", ';'.join(requests.compat.quote_plus(str(x)) for x in iterator))
+                    except TypeError:
+                        # it's not an iterable, represent as string
+                        endpoint = endpoint.replace("{" + k + "}", requests.compat.quote_plus(str(value)))
+
                 kwargs.pop(k, None)
 
         date_time_keys = ['fromdate', 'todate', 'since', 'min', 'max']