This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
add revisor using git diff #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+131
to
+132
| # We could do all edits asynchronously; of course, this risks getting rate limited and probably not worth effort | ||
| await revise_edit(file_edit) |
There was a problem hiding this comment.
it might be worth the effort since it'd reduce latency a lot (and I've actually already implemented a balancer in a different repo) But yeah not for this PR, for now let's just try to get an experimental feature, not perfected yet
|
Doesn't seem reliable enough yet to be default-on but maybe we could merge as an experimental feature, since you've laid the groundwork for it and perhaps with more tweaks it could be good enough |
biobootloader
approved these changes
Jan 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Pull Request Checklist