This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
Remove colored and highlight #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| errors = list[str]() | ||
| while self.edits: | ||
| error = self.undo() | ||
| if error: | ||
| errors.append(error) | ||
| return "\n".join(errors) | ||
| errors += error |
There was a problem hiding this comment.
Should this still be .append (since it's a list)?
Comment on lines
+141
to
+142
| if (isinstance(line, str) and line.strip()) or ( | ||
| isinstance(line, Tuple) and line[0].strip() |
There was a problem hiding this comment.
Is line.strip() in the if statement just checking if the line is empty or not? Might be more readable to do line == "" or line != ""
There was a problem hiding this comment.
We want to make sure it has stuff other than just whitespace; otherwise I would just do if line
|
|
||
| from mentat.session_context import SESSION_CONTEXT | ||
|
|
||
| FormattedString = str | Tuple[str, Dict[str, Any]] | List[Tuple[str, Dict[str, Any]]] |
There was a problem hiding this comment.
Might be better to make FormattedString an actual class instead of a union of all these types.
There was a problem hiding this comment.
Maybe; I'll add a TODO but I want to get this PR merged quickly because I need it in order to work on my textual PR.
waydegilliam
approved these changes
Jan 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all uses of colored and highlight so that all coloring is handled entirely by the client (which is necessary for the Textual client). Ideally we eventually move completely over to styles instead of colors, but this is a step in that direction.
Pull Request Checklist