This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
Python client default mentat export #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now import the PythonClient via from mentat import Mentat. * Docs updated * Comments added to python_client * tests and benchmarks updated to use new import
This fixes an import issue.
waydegilliam
reviewed
Feb 2, 2024
mentat/python_client/client.py
Outdated
Comment on lines
114
to
115
| """Initiates shutdown of the client, ensuring all tasks are cancelled and the session is properly closed.""" | ||
| """Sends the stop signal to the session and returns when client is fully shutdown.""" |
There was a problem hiding this comment.
Nit: make this a single block comment
waydegilliam
reviewed
Feb 2, 2024
| readme_path = os.path.join(Path(__file__).parent, "README.md") | ||
| with open(readme_path, "r", encoding="utf-8") as f: | ||
| long_description = f.read() | ||
|
|
||
|
|
||
| setup( | ||
| name="mentat", | ||
| version=__version__, | ||
| version="1.0.9", |
There was a problem hiding this comment.
Why do we hardcode this over using __version__?
There was a problem hiding this comment.
The reason I made this change was because we can't import from mentat in setup anymore because the default export will fail as requirements are not installed yet. The number has to be hardcoded somewhere and I thought here made sense but also considered putting it in a VERSION file which I've seen some packages do.
I'm down to do it a different way if you have opinions.
waydegilliam
approved these changes
Feb 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now import the PythonClient via
from mentat import Mentat.Pull Request Checklist