First pass of warning cleanup

This fixes g++ -Wall to compile warning free Signed-off-by: Kimball Thurston <[email protected]>
AcademySoftwareFoundation · Jul 23, 2019 · b5653ed · b5653ed
1 parent b9d93bd
commit b5653ed
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 26 deletions.
diff --git a/IlmBase/Half/half.h b/IlmBase/Half/half.h
@@ -96,9 +96,12 @@ class half
     // Constructors
     //-------------
 
-    half ();			// no initialization
+    half () = default;			// no initialization
     half (float f);
-
+    // rule of 5
+    ~half () = default;
+    half (const half &) = default;
+    half (half &&) noexcept = default;
 
     //--------------------
     // Conversion to float
@@ -118,7 +121,8 @@ class half
     // Assignment
     //-----------
 
-    half &		operator = (half  h);
+    half &		operator = (const half  &h) = default;
+    half &		operator = (half  &&h) noexcept = default;
     half &		operator = (float f);
 
     half &		operator += (half  h);
@@ -417,17 +421,6 @@ HALF_EXPORT void        printBits   (char  c[35], float f);
 //---------------------------------------------------------------------------
 
 
-//--------------------
-// Simple constructors
-//--------------------
-
-inline
-half::half ()
-{
-    // no initialization
-}
-
-
 //----------------------------
 // Half-from-float constructor
 //----------------------------
@@ -575,14 +568,6 @@ half::operator - () const
 }
 
 
-inline half &
-half::operator = (half h)
-{
-    _h = h._h;
-    return *this;
-}
-
-
 inline half &
 half::operator = (float f)
 {

diff --git a/IlmBase/Half/halfFunction.h b/IlmBase/Half/halfFunction.h
@@ -148,7 +148,6 @@ halfFunction<T>::halfFunction (Function f,
 {
 #ifndef ILMBASE_HAVE_LARGE_STACK
     _lut = new T[1<<16];
-    memset (_lut, 0 , (1<<16) * sizeof(T));
 #endif
 
     for (int i = 0; i < (1 << 16); i++)

diff --git a/IlmBase/ImathTest/testFrustum.cpp b/IlmBase/ImathTest/testFrustum.cpp
@@ -225,7 +225,7 @@ testFrustum ()
 	(void)badFrustum.projectionMatrix();
 	assert (!"near == far didn't throw an exception");
     }
-    catch (IEX_NAMESPACE::DivzeroExc)
+    catch (IEX_NAMESPACE::DivzeroExc &)
     {
         caught = true;
     }
@@ -239,7 +239,7 @@ testFrustum ()
 	(void)badFrustum.projectionMatrix();
 	assert (!"left == right didn't throw an exception");
     }
-    catch (IEX_NAMESPACE::DivzeroExc)
+    catch (IEX_NAMESPACE::DivzeroExc &)
     {
         caught = true;
     }
@@ -253,7 +253,7 @@ testFrustum ()
 	(void)badFrustum.projectionMatrix();
 	assert (!"top == bottom didn't throw an exception");
     }
-    catch (IEX_NAMESPACE::DivzeroExc)
+    catch (IEX_NAMESPACE::DivzeroExc &)
     {
         caught = true;
     }