Speedtest and Inversion python bindings for Arrays #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Thompson <[email protected]>
Signed-off-by: Owen Thompson <[email protected]>
Signed-off-by: Owen Thompson <[email protected]>
Signed-off-by: Owen Thompson <[email protected]>
Signed-off-by: Owen Thompson <[email protected]>
Signed-off-by: Owen Thompson <[email protected]>
…oses. Signed-off-by: Owen Thompson <[email protected]>
…eck for cmake version. Signed-off-by: Owen Thompson <[email protected]>
Signed-off-by: Owen Thompson <[email protected]>
Signed-off-by: Owen Thompson <[email protected]>
cary-ilm
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull would add:
1: Optional speed tests (in Python 3*) that can be performed by configuring -DPYTHON=ON and -DSPEED=ON when running cmake configuration. (Only needs to be done once as it is a toggle.)
* These tests only build for Python 3 because Python 3 has more accurate options for time measurement.
2: New python bindings permitting calls to .inverse(), invert(), gjInverse(), and gjInvert() on M22xArray, M33xArray, M44xArray matrix objects. Tests demonstrate that this improves speed dramatically (over x20 faster) as it avoids some Pythonic overhead.
Bindings like this can be added to other Matrix functions, but whether that is imperative has not yet been decided.
A feature for running these tests against a 'baseline' can be added in the future as well.