Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PYIMATH_OVERRIDE_PYTHON_INSTALL_DIR to specify destination python modules #200

Conversation

cary-ilm
Copy link
Member

The previous PYIMATH_OVERRIDE_PYTHON2_INSTALL_DIR and
PYIMATH_OVERRIDE_PYTHON3_INSTALL_DIR options were left over from when
python2 and python3 could be built simultaneously, and even worse,
they were ignored. There's no need for two variables now. This takes
effect only if it is provided.

Also, INSTALL.md properly mentions PYTHON, USE_PYTHON2, and
PYIMATH_OVERRIDE_PYTHON_INSTALL_DIR.

Signed-off-by: Cary Phillips [email protected]

… modules

The previous PYIMATH_OVERRIDE_PYTHON2_INSTALL_DIR and
PYIMATH_OVERRIDE_PYTHON3_INSTALL_DIR options were left over from when
python2 and python3 could be built simultaneously, and even worse,
they were ignored. There's no need for two variables now. This takes
effect only if it is provided.

Also, INSTALL.md properly mentions PYTHON, USE_PYTHON2, and
PYIMATH_OVERRIDE_PYTHON_INSTALL_DIR.

Signed-off-by: Cary Phillips <[email protected]>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cary-ilm cary-ilm merged commit 5bd391a into AcademySoftwareFoundation:master Aug 24, 2021
cary-ilm added a commit to cary-ilm/Imath that referenced this pull request Aug 30, 2021
… modules (AcademySoftwareFoundation#200)

The previous PYIMATH_OVERRIDE_PYTHON2_INSTALL_DIR and
PYIMATH_OVERRIDE_PYTHON3_INSTALL_DIR options were left over from when
python2 and python3 could be built simultaneously, and even worse,
they were ignored. There's no need for two variables now. This takes
effect only if it is provided.

Also, INSTALL.md properly mentions PYTHON, USE_PYTHON2, and
PYIMATH_OVERRIDE_PYTHON_INSTALL_DIR.

Signed-off-by: Cary Phillips <[email protected]>
cary-ilm added a commit that referenced this pull request Sep 1, 2021
… modules (#200)

The previous PYIMATH_OVERRIDE_PYTHON2_INSTALL_DIR and
PYIMATH_OVERRIDE_PYTHON3_INSTALL_DIR options were left over from when
python2 and python3 could be built simultaneously, and even worse,
they were ignored. There's no need for two variables now. This takes
effect only if it is provided.

Also, INSTALL.md properly mentions PYTHON, USE_PYTHON2, and
PYIMATH_OVERRIDE_PYTHON_INSTALL_DIR.

Signed-off-by: Cary Phillips <[email protected]>
@cary-ilm cary-ilm added the v3.1.3 label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants