Remove MACOSX_RPATH forcing #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mwestphal
force-pushed
the
remove_macosx_rpath
branch
from
9ddb9e7
to
6aa4b01
Compare
Signed-off-by: Mathieu Westphal <[email protected]>
mwestphal
force-pushed
the
remove_macosx_rpath
branch
from
6aa4b01
to
b18c83b
Compare
|
Yes, it's no longer necessary to set that variable manually to ON, and us not setting it means that it won't override user's setting it themselves deliberately. |
cary-ilm
pushed a commit
to cary-ilm/Imath
that referenced
this pull request
Feb 27, 2023
Signed-off-by: Mathieu Westphal <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Feb 28, 2023
Signed-off-by: Mathieu Westphal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With cmake 3.0.0, CMP0042 applies and the default value of MACOSX_RPATH is true, this block is not needed anymore.
Setting this is a bad practice because in some cases one needs to disabled it.