Fix coverage analysis for .c files #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the coverage analysis has been completely missing .c files. - Set CMAKE_C_FLAGS/CMAKE_C_OUTPUT_EXTENSION_REPLACE just like CXX - Fix run_gcov.sh to deduce the source file by examining the .o.d file rather than simply replacing .gcno with .cpp, which misses .c files - Add ImathHalfPerfTest to the test suite Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
meshula
approved these changes
Mar 16, 2023
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
May 19, 2023
* Fix coverage analysis for .c files Looks like the coverage analysis has been completely missing .c files. - Set CMAKE_C_FLAGS/CMAKE_C_OUTPUT_EXTENSION_REPLACE just like CXX - Fix run_gcov.sh to deduce the source file by examining the .o.d file rather than simply replacing .gcno with .cpp, which misses .c files - Add ImathHalfPerfTest to the test suite Signed-off-by: Cary Phillips <[email protected]> * confirm dependency file exists Signed-off-by: Cary Phillips <[email protected]> --------- Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
May 21, 2023
* Fix coverage analysis for .c files Looks like the coverage analysis has been completely missing .c files. - Set CMAKE_C_FLAGS/CMAKE_C_OUTPUT_EXTENSION_REPLACE just like CXX - Fix run_gcov.sh to deduce the source file by examining the .o.d file rather than simply replacing .gcno with .cpp, which misses .c files - Add ImathHalfPerfTest to the test suite Signed-off-by: Cary Phillips <[email protected]> * confirm dependency file exists Signed-off-by: Cary Phillips <[email protected]> --------- Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the coverage analysis has been completely missing .c files.
Set CMAKE_C_FLAGS/CMAKE_C_OUTPUT_EXTENSION_REPLACE just like CXX
Fix run_gcov.sh to deduce the source file by examining the .o.d file rather than simply replacing .gcno with .cpp, which misses .c files
Add ImathHalfPerfTest to the test suite