Extend test coverage #310
Merged
Extend test coverage #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cary-ilm
commented
Mar 20, 2023
cary-ilm
commented
- more colors for rgb2hsv/hsv2rgb
- misc Frustum methods
- FrustumTest::completelyContains
- drand48/lrand48
- 2D color array
- PyImathTestC tests wrap/convert (an internal ILM test that never got uploaded)
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
meshula
approved these changes
Mar 20, 2023
|
Good progress on the coverage improvements! What was the % at a couple weeks ago? |
|
Imath is at 81.9%, up from 75.4%. Progress is slow. The main Imath library is at 90.4%, but the python bindings are at 69.3%. I was able to pull in some tests from ILM that had never gotten uploaded, which helped. It's really tedious getting the python script to use all the operators, there are so many. |
|
OpenEXR is at 82.8%, up from 68.1%. |
cary-ilm
added a commit
to cary-ilm/Imath
that referenced
this pull request
May 19, 2023
* PyImathTestC Signed-off-by: Cary Phillips <[email protected]> * Random, Color, Frustum, PyImathTestC Signed-off-by: Cary Phillips <[email protected]> * Python_VERSION Signed-off-by: Cary Phillips <[email protected]> * set PYTHONPATH property Signed-off-by: Cary Phillips <[email protected]> * remove <iostream> Signed-off-by: Cary Phillips <[email protected]> --------- Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
May 21, 2023
* PyImathTestC Signed-off-by: Cary Phillips <[email protected]> * Random, Color, Frustum, PyImathTestC Signed-off-by: Cary Phillips <[email protected]> * Python_VERSION Signed-off-by: Cary Phillips <[email protected]> * set PYTHONPATH property Signed-off-by: Cary Phillips <[email protected]> * remove <iostream> Signed-off-by: Cary Phillips <[email protected]> --------- Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.