Replace NOTICE with STATUS for CMake messages #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cary Phillips <[email protected]>
lgritz
reviewed
Jan 28, 2021
config/CMakeLists.txt
Outdated
| @@ -57,7 +57,7 @@ if(IMATH_INSTALL_PKG_CONFIG) | |||
| endfunction() | |||
| imath_pkg_config_help(../Imath.pc.in) | |||
| else() | |||
| message(NOTICE "-- WARNING pkg-config generation disabled") | |||
| message(STATUS "-- WARNING pkg-config generation disabled") | |||
There was a problem hiding this comment.
There is also "WARNING", might it be appropriate here?
There was a problem hiding this comment.
Also, I think that if you use STATUS, you can remove the "-- " because that's automatically added by status.
There was a problem hiding this comment.
The only way to get here is by explicitly setting IMATH_INSTALL_PKG_CONFIG=0, so this message is simply confirming what settings have been provided. Warning implies there might be something wrong, which doesn't seem appropriate. Status seems appropriate since it's merely echoing what it's been told.
There was a problem hiding this comment.
Then why does the message itself say "WARNING"?
There was a problem hiding this comment.
N/M, I see you removed that word now
lgritz
approved these changes
Jan 28, 2021
Signed-off-by: Cary Phillips <[email protected]>
lgritz
approved these changes
Jan 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cary Phillips [email protected]