PR: Implement support for pyright and typing annotations.
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmansencal
force-pushed
the
feature/typing_annotations
branch
5 times, most recently
from
cd67f75 to
1666284
Compare
|
PR is good besides the CLA shenanigans. I haven't added annotations yet though. This could come with another PR. |
doug-walker
approved these changes
Jan 30, 2024
|
Merging this one, we don't have the logs for the tests but I will fix any issues in a new PR. |
Signed-off-by: Thomas Mansencal <[email protected]>
Define a good baseline without errors or warnings. Signed-off-by: Thomas Mansencal <[email protected]>
…package. Signed-off-by: Thomas Mansencal <[email protected]>
KelSolaar
force-pushed
the
feature/typing_annotations
branch
from
ad9963a to
113ee10
Compare
KelSolaar
merged commit e19ea45
into
AcademySoftwareFoundation:main
3 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #114.