New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to allow use of AWS ECR #4

Open

aliciasteen wants to merge 1 commit into Accenture:master from aliciasteen:master

aliciasteen commented Jan 17, 2017

This is to allow pushing to AWS ECR instead of dockerhub


          Updated to allow use of AWS ECR

78235ef

nickdgriffin commented Jan 20, 2017

Thanks for the PR!

Couple of tweaks I'd like to suggest to clarify the environment variables please:

I think "IMAGE_REPO" should become "SCM_REPO" so it's not confusing the term with the Docker term
I think "IMAGE_NAME" should be the full name, e.g. /, replacing "IMAGE_TAG"
- Where you need just the part I suggest calling it "IMAGE_REPO" as that's the Docker term
I think "IMAGE_TAG" should be the actual tag name and replace ${B}

SachinKSingh28 mentioned this pull request

Single job for docker CI #6

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet