Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Change NGINX countdown timer to pretty one #143

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Change NGINX countdown timer to pretty one #143

merged 1 commit into from
Sep 26, 2016

Conversation

anton-kasperovich
Copy link
Contributor

Just to make all countdown timers looks the same...

@kramos
Copy link
Contributor

kramos commented Sep 24, 2016

Hi @anton-kasperovich I admire your dedication to consistency! Only one small concern with this, TOOL_SLEEP_TIME = 30 seconds, so you are increasing the NGINX sleep from 5 to 30 with the above change.

Would this be better?

until [[ $(curl -I -s -u ${INITIAL_ADMIN_USER}:${INITIAL_ADMIN_PASSWORD_PLAIN} http://${TARGET_HOST}/|head -n 1|cut -d$' ' -f2) == 200 ]]; do pretty_sleep 5 Nginx; done

(I tested it).

@anton-kasperovich
Copy link
Contributor Author

Hi @kramos , on my environment, there's not much difference, as it's sleeps more than ~60 seconds, but it looks like on Travis CI it's a bit faster and totally make sense to revert to 5 seconds sleep. Good point, updated this PR.

@kramos
Copy link
Contributor

kramos commented Sep 25, 2016

LGTM

@nickdgriffin
Copy link
Contributor

LGTM.

@nickdgriffin nickdgriffin merged commit 6ef652f into Accenture:master Sep 26, 2016
@nickdgriffin nickdgriffin added this to the 0.3.0 milestone Jan 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants