This repository has been archived by the owner on Dec 4, 2020. It is now read-only.
Updated compose cli to check for both http and https protocol #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - Run: export DOCKER\_HOST=tcp://\<SwarmMasterIP\>:2375 | ||
| - You can get the `SwarmMasterIP` from cloudformation outputs as mentioned in above section. | ||
| - Run: export TARGET\_HOST=\<ELBPublicDNSName\> | ||
| - You can get the `ELBPublicDNSName` from cloudformation outputs as mentioned in above section. | ||
| - Run: echo "export PROTO=https" > env.override.sh |
There was a problem hiding this comment.
I'm thinking about the case, if i will add some env variables in env.override.sh in advance and after i will run ./adop compose init, this line will overwrite all my changes. Maybe it would better to use append operator ">>", what do you think?
SachinKSingh28
force-pushed
the
feature/fix_target_host
branch
from
be44540 to
83e0021
Compare
|
Updated the README file and squashed the changes in one commit. |
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes fix for compose cli to handle ssl enabled stacks and also updated readme for swarm to override PROTO environment variable.