Fix for using multiple flags with adop compose init #166
Conversation
cmd/compose
Outdated
| shift | ||
| ;; | ||
| *) | ||
| shift |
There was a problem hiding this comment.
Was this added to prevent an infinite loop from occurring? (Line 104)
There was a problem hiding this comment.
I added this to just shift through any invalid flags, maybe I should echo an error message as well?
There was a problem hiding this comment.
Yeah I think that'd be useful - I think it should print a helpful message and exit please.
statlus
force-pushed
the
feature/composefix
branch
2 times, most recently
from
9e7d798 to
daa4e82
Compare
|
I've changed the catchall option to echo a message and exit 1. |
|
Finally got around to testing this, and it's all dandy from Ubuntu 16.04. I'll give it a shot from Windows too soon. @anton-kasperovich Would you be able to give it a quick go at some point on OSX please? |
|
Tested from Windows 7 with the latest version of Docker Toolbox and it works fine. @statlus Could you rebase on master just so the history is tidier please? |
|
Tested from macOS Sierra (10.12.3) and it works. Thank you! |
statlus
force-pushed
the
feature/composefix
branch
from
daa4e82 to
76a3b02
Compare
|
Hi @nickdgriffin, I've rebased the change on master. |
|
Great, thanks. So, LGTM! |
Wrapped the case statement at the start of adop compose init() with a while loop so all options are read instead of just the first one.