This repository has been archived by the owner on Dec 4, 2020. It is now read-only.
Changed port instruction format in docker-compose file according to the latest format #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Ilia, This is a duplication of #229 so my comment still stands - has this been tested against the version of Docker Compose stated in our pre-requisites as the version we are compatible with? Thanks, |
|
@nickdgriffin I tested this PR with Docker 1.10/1.12/1.13/17.06 and Docker compose v1.9.0, and it is working |
|
Thanks @arthur-kovalenko ! Was on vacation with no chance to test this. |
|
Cool thanks @arthur-kovalenko , I'll merge then. |
This was referenced Sep 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This is an important change that is blocking adop installation using existing docker-compose.yml on a server or Swarm API where docker-compose is v1.13+
Can it be merged to master?
@nickdgriffin @SachinKSingh28