Modifying configuration in ldap.xml to support on-premise ldap #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes have been made to ldap.xml.
These lines have been added:
The userSubtree and groupSubtree were already set to false in ADOP. However, on some projects ldap can be set up to utilise them. With this change the two parameters can be defined to be true from the docker-compose.yml file in ADOP.
The second change is:
The previous syntax ${parameter:-value} was modified to ${parameter-value}. In our set up we do not define LDAP_USER_PASSWORD_ATTRIBUTE and this change is needed in order not to be set to the default value which is password.
The change has been tested and working as expected.