Updated nginx configuration for kibana running with context path #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -95,6 +72,5 @@ server { | |||
| proxy_redirect off; | |||
| proxy_pass http://ldap-phpadmin; | |||
| } | |||
| include /etc/nginx/sites-enabled/service-extension/*.conf; | |||
There was a problem hiding this comment.
Why we want to remove this line? It was introduced in #22
SachinKSingh28
force-pushed
the
feature/kibana-rule-fix
branch
from
3d3f781 to
74d7202
Compare
|
@anton-kasperovich : Thanks for the review! I have added the server-extension configuration back in. It was accidentally removed. Also squashed the commits. |
|
Closing this PR as the same issue has been fixed in PR #29 |
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to be able to fix the issue described in #25
Also simplifies the rules that we have in tools-context for kibana.
This is dependent on https://github.com/SachinKSingh28/adop-kibana repository and image produced from it.