Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Load_Platform_Extension to support multiple instances #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aliciasteen
Copy link

Updated the load_platform_extension to support creation of multiple instances to work as it does with one instance

@nickdgriffin
Copy link
Contributor

Hello!

Thanks for the PR for this, I have a couple of cosmetic tweaks please:

I think we need to have a think about the Nginx handling at the end as if there are multiple hosts we don't know which one should be proxied, so I think it'd make sense for the template to contain an output that states the IP that should be used - the job can then lift that to do the replace in "ec2-extension.conf". @dsingh07 - what do you think?

Thanks,
Nick

@dsingh07
Copy link
Contributor

dsingh07 commented Sep 7, 2016

Hi @aliciasteen @nickdgriffin

Currently the Nginx handling will work in a way such that if the file exists, it will look for a variable called INSTANCE_ID, which in the case of two instances will be in a list.

So yes, I agree that the template should contain an output of the IP that needs to be proxied. This may mean we need to rewrite some of our existing platform extensions (i.e sample and Chef) to give this output.

Thanks,
Dharmanshu

@aliciasteen
Copy link
Author

Have updated the split lines and echo instanceIDs

@aliciasteen
Copy link
Author

Updated changes ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants