Comments addressed

Comments of the PR wso2#384
Achintha444 · Jun 9, 2023 · 83fabfe · 83fabfe
1 parent 732b9bc
commit 83fabfe
Show file tree

Hide file tree

Showing 38 changed files with 38 additions and 26 deletions.
diff --git a/...min-app/components/sections/sections/getStartedSection/otherComponents/getStartedText.tsx b/...min-app/components/sections/sections/getStartedSection/otherComponents/getStartedText.tsx
@@ -25,6 +25,7 @@ import getStartedWelcomeImage from
 import styles from "../../../../../styles/Settings.module.css";
 
 export default function GetStartedText() {
+
     return (
         <div className={ styles.getStartedSectionComponentGetStartedTextDiv }>
             <Panel bordered className={ styles.getStartedSectionComponentGetStartedTextPanel }>

diff --git a/...admin-app/components/sections/sections/settingsSection/idpSection/idpSectionComponent.tsx b/...admin-app/components/sections/sections/settingsSection/idpSection/idpSectionComponent.tsx
@@ -92,6 +92,7 @@ export default function IdpSectionComponent(props: IdpSectionComponentProps) {
     };
 
     const onIdpCreated = (response: IdentityProvider): void => {
+
         if (response) {
             successTypeDialog(toaster, "Success", "Identity Provider is created successfully");
 

diff --git a/...ections/settingsSection/idpSection/otherComponents/buttonGroupIdentityProviderDetails.tsx b/...ections/settingsSection/idpSection/otherComponents/buttonGroupIdentityProviderDetails.tsx
@@ -86,6 +86,7 @@ export default function ButtonGroupIdentityProviderDetails(props : ButtonGroupId
     }, [ idpDetails, applicationDetail ]);
 
     const onIdpDelete = (response: boolean): void => {
+
         if (response) {
             successTypeDialog(toaster, "Success", "Identity provider is deleted successfully");
         } else {

diff --git a/...ns/sections/settingsSection/idpSection/otherComponents/confirmAddRemoveLoginFlowModal.tsx b/...ns/sections/settingsSection/idpSection/otherComponents/confirmAddRemoveLoginFlowModal.tsx
@@ -209,7 +209,7 @@ function ApplicationListAvailable(props: ApplicationListAvailableProps) {
  * 
  * @param prop - application
  * 
- * @returns The component to show the applicaiton name and the description
+ * @returns The component to show the applicaiton name and the description.
  */
 function ApplicationListItem(props: ApplicationListItemProps) {
 

diff --git a/...sections/sections/settingsSection/idpSection/otherComponents/idpCreateModal/idpCreate.tsx b/...sections/sections/settingsSection/idpSection/otherComponents/idpCreateModal/idpCreate.tsx
@@ -66,7 +66,6 @@ export default function IdpCreate(prop: IdpCreateProps) {
                     onCancel={ onCancel } />);
 
             case ENTERPRISE_ID:
-
                 return (<ExternalIdentityProvider
                     session={ session }
                     template={ template }

diff --git a/.../sections/sections/settingsSection/manageUserSection/otherComponents/addUserComponent.tsx b/.../sections/sections/settingsSection/manageUserSection/otherComponents/addUserComponent.tsx
@@ -214,6 +214,7 @@ export default function AddUserComponent(props: AddUserComponentProps) {
 }
 
 function EmailInvitePanel() {
+
     return (
         <Panel bordered>
             <Stack spacing={ 30 }>

diff --git a/...dmin-app/data-access/data-access-common-api-util/src/lib/apiUtil/api/apiRequestOptions.ts b/...dmin-app/data-access/data-access-common-api-util/src/lib/apiUtil/api/apiRequestOptions.ts
@@ -28,10 +28,12 @@ import { Session } from "next-auth";
  * @returns header object that can used for IS API calls
  */
 export function requestOptions(session: Session): RequestInit {
+
     return apiRequestOptions(session, getHostedUrl());
 }
 
 export function requestOptionsWithBody(session: Session, method: RequestMethod, body: BodyInit): RequestInit {
+
     return apiRequestOptionsWithBody(session, method, body, getHostedUrl());
 }
 

diff --git a/...a-access/data-access-common-models-util/src/lib/identityProvider/identityProviderUtils.ts b/...a-access/data-access-common-models-util/src/lib/identityProvider/identityProviderUtils.ts
@@ -47,6 +47,7 @@ export function getImageForTheIdentityProvider(templateId: string): string {
  * @returns callBackUrl of the idp.
  */
 export function getCallbackUrl(orgId: string): string {
+
     return `${getOrgUrl(orgId)}/commonauth`;
 }
 
@@ -86,7 +87,6 @@ export function setIdpTemplate(model: IdentityProviderTemplateModel, templateId:
     model.federatedAuthenticators.authenticators[0].isEnabled = true;
 
     return model;
-
 }
 
 /**

diff --git a/...src/lib/controller/application/controllerGetApplication/controllerDecodeGetApplication.ts b/...src/lib/controller/application/controllerGetApplication/controllerDecodeGetApplication.ts
@@ -34,7 +34,6 @@ export async function controllerDecodeGetApplication(session: Session, id: strin
         await commonControllerDecode(() => controllerCallGetApplication(session, id), null) as Application | null);
 
     return res;
-
 }
 
 export default controllerDecodeGetApplication;
diff --git a/...ntroller/application/controllerListAllApplications/controllerDecodeListAllApplications.ts b/...ntroller/application/controllerListAllApplications/controllerDecodeListAllApplications.ts
@@ -33,7 +33,6 @@ export async function controllerDecodeListAllApplications(session: Session): Pro
         ApplicationList | null);
 
     return res;
-
 }
 
 export default controllerDecodeListAllApplications;
diff --git a/...er/application/controllerListCurrentApplication/controllerDecodeListCurrentApplication.ts b/...er/application/controllerListCurrentApplication/controllerDecodeListCurrentApplication.ts
@@ -34,7 +34,6 @@ export async function controllerDecodeListCurrentApplication(session: Session):
         ApplicationList | null);
 
     return res;
-
 }
 
 export default controllerDecodeListCurrentApplication;
diff --git a/...lication/controllerPatchApplicationAuthSteps/controllerDecodePatchApplicationAuthSteps.ts b/...lication/controllerPatchApplicationAuthSteps/controllerDecodePatchApplicationAuthSteps.ts
@@ -104,6 +104,7 @@ function addRemoveAuthSequence(template: Application, idpTempleteId: string, idp
         authenticationSequenceModel.steps.forEach((step: AuthenticationSequenceStep) => {
             step.options = step.options.filter((option: AuthenticationSequenceStepOption) => {
                 if (option.idp === idpName) {
+
                     return false;
                 } else if (option.authenticator === "BasicAuthenticator") {
                     basicCheck = true;
@@ -156,6 +157,7 @@ export async function controllerDecodePatchApplicationAuthSteps(
         () => controllerCallPatchApplicationAuthSteps(session, applicationId, authenticationSequenceModel), null);
 
     if (res) {
+
         return true;
     }
 

diff --git a/...ata-access-controller/src/lib/controller/controllerSwitchOrg/controllerDecodeSwitchOrg.ts b/...ata-access-controller/src/lib/controller/controllerSwitchOrg/controllerDecodeSwitchOrg.ts
@@ -33,13 +33,17 @@ function getOrgId(token: JWT): string {
 
     if (token.user) {
         if (token.user.user_organization) {
+
             return token.user.user_organization;
         } else if (config.CommonConfig.ApplicationConfig.SampleOrganization[0]) {
+
             return config.CommonConfig.ApplicationConfig.SampleOrganization[0].id;
         } else {
+
             return token.user.org_id;
         }
     } else {
+
         return config.CommonConfig.ApplicationConfig.SampleOrganization[0].id;
     }
 
@@ -61,7 +65,6 @@ export async function controllerDecodeSwitchOrg(token: JWT): Promise<OrgSession
         (await commonControllerDecode(() => controllerCallSwitchOrg(subOrgId, accessToken), null) as OrgSession | null);
 
     return res;
-
 }
 
 export default controllerDecodeSwitchOrg;
diff --git a/...entityProvider/controllerCreateIdentityProvider/controllerDecodeCreateIdentityProvider.ts b/...entityProvider/controllerCreateIdentityProvider/controllerDecodeCreateIdentityProvider.ts
@@ -79,7 +79,6 @@ export async function controllerDecodeCreateIdentityProvider(session: Session, t
         null) as IdentityProvider | null);
 
     return res;
-
 }
 
 export default controllerDecodeCreateIdentityProvider;
diff --git a/...entityProvider/controllerDeleteIdentityProvider/controllerDecodeDeleteIdentityProvider.ts b/...entityProvider/controllerDeleteIdentityProvider/controllerDecodeDeleteIdentityProvider.ts
@@ -36,7 +36,6 @@ export async function controllerDecodeDeleteIdentityProvider(session: Session, i
     }
 
     return res;
-
 }
 
 export default controllerDecodeDeleteIdentityProvider;
diff --git a/...ider/controllerGetDetailedIdentityProvider/controllerDecodeGetDetailedIdentityProvider.ts b/...ider/controllerGetDetailedIdentityProvider/controllerDecodeGetDetailedIdentityProvider.ts
@@ -35,7 +35,6 @@ export async function controllerDecodeGetDetailedIdentityProvider(session: Sessi
         null) as IdentityProvider | null);
 
     return res;
-
 }
 
 export default controllerDecodeGetDetailedIdentityProvider;
diff --git a/...ovider/controllerGetFederatedAuthenticators/controllerDecodeGetFederatedAuthenticators.ts b/...ovider/controllerGetFederatedAuthenticators/controllerDecodeGetFederatedAuthenticators.ts
@@ -37,7 +37,6 @@ export async function controllerDecodeGetFederatedAuthenticators(session: Sessio
         null) as IdentityProviderFederatedAuthenticator | null);
 
     return res;
-
 }
 
 export default controllerDecodeGetFederatedAuthenticators;
diff --git a/.../controllerUpdateFederatedAuthenticators/controllerDecodeUpdateFederatedAuthenticators.ts b/.../controllerUpdateFederatedAuthenticators/controllerDecodeUpdateFederatedAuthenticators.ts
@@ -61,7 +61,6 @@ export async function controllerDecodeUpdateFederatedAuthenticators(
         null) as IdentityProviderFederatedAuthenticator | null);
 
     return res;
-
 }
 
 export default controllerDecodeUpdateFederatedAuthenticators;
diff --git a/...ess-controller/src/lib/controller/role/controllerCreateRole/controllerDecodeCreateRole.ts b/...ess-controller/src/lib/controller/role/controllerCreateRole/controllerDecodeCreateRole.ts
@@ -28,6 +28,7 @@ function getUsersList(users: string[]): RoleUsers[] {
 }
 
 function getRoleBody(displayName: string, permissions: string[], users: string[]): Role {
+
     return {
         "displayName": displayName,
         "groups": [],

diff --git a/...r/role/controllerEditRolesToAddOrRemoveUser/controllerDecodeEditRolesToAddOrRemoveUser.ts b/...r/role/controllerEditRolesToAddOrRemoveUser/controllerDecodeEditRolesToAddOrRemoveUser.ts
@@ -22,10 +22,12 @@ import { Session } from "next-auth";
 import { controllerDecodePatchRole } from "../controllerPatchRole/controllerDecodePatchRole";
 
 function getRolesThatNeedToAddUser(initRoleList: string[], roleList: string[]): string[] {
+
     return roleList.filter(roleUri => !initRoleList.includes(roleUri));
 }
 
 function getRolesThatNeedToRemoveUser(initRoleList: string[], roleList: string[]): string[] {
+
     return initRoleList.filter(roleUri => !roleList.includes(roleUri));
 }
 
@@ -74,6 +76,7 @@ export async function controllerDecodeEditRolesToAddOrRemoveUser(
     session: Session, userId: string, initRoleList: string[], roleList: string[]): Promise<boolean> {
 
     try {
+
         return getRoleDetailsForAdd(session, userId, initRoleList, roleList)
             .then(
                 (res: boolean) => {
@@ -90,7 +93,6 @@ export async function controllerDecodeEditRolesToAddOrRemoveUser(
 
         return false;
     }
-
 }
 
 export default controllerDecodeEditRolesToAddOrRemoveUser;
diff --git a/...ta-access-controller/src/lib/controller/role/controllerGetRole/controllerDecodeGetRole.ts b/...ta-access-controller/src/lib/controller/role/controllerGetRole/controllerDecodeGetRole.ts
@@ -33,7 +33,6 @@ export async function controllerDecodeGetRole(session: Session, roleUri: string)
     const res = (await commonControllerDecode(() => controllerCallGetRole(session, roleUri), null) as Role | null);
 
     return res;
-
 }
 
 export default controllerDecodeGetRole;
diff --git a/...controller/src/lib/controller/role/controllerListAllRoles/controllerDecodeListAllRoles.ts b/...controller/src/lib/controller/role/controllerListAllRoles/controllerDecodeListAllRoles.ts
@@ -37,7 +37,6 @@ export async function controllerDecodeListAllRoles(session: Session): Promise<Ro
     }
 
     return res;
-
 }
 
 export default controllerDecodeListAllRoles;
diff --git a/...ccess-controller/src/lib/controller/role/controllerPatchRole/controllerDecodePatchRole.ts b/...ccess-controller/src/lib/controller/role/controllerPatchRole/controllerDecodePatchRole.ts
@@ -24,6 +24,7 @@ import { Session } from "next-auth";
 import { controllerCallPatchRole } from "./controllerCallPatchRole";
 
 function getAddReplaceBody(patchMethod: PatchMethod, path: string, value: string[] | string): PatchBody {
+
     return {
         "operations": [
             {
@@ -36,6 +37,7 @@ function getAddReplaceBody(patchMethod: PatchMethod, path: string, value: string
 }
 
 function getRemoveBody(patchMethod: PatchMethod, path: string, value: string[] | string): PatchBody {
+
     return {
         "operations": [
             {

diff --git a/...-access-controller/src/lib/controller/role/controllerUserRole/controllerDecodeUserRole.ts b/...-access-controller/src/lib/controller/role/controllerUserRole/controllerDecodeUserRole.ts
@@ -33,7 +33,6 @@ export async function controllerDecodeUserRole(session: Session, id: string): Pr
     const res = (await commonControllerDecode(() => controllerCallUserRole(session, id), null) as Role[] | null);
 
     return res;
-
 }
 
 export default controllerDecodeUserRole;
diff --git a/...data-access-controller/src/lib/controller/user/controllerAddUser/controllerCallAddUser.ts b/...data-access-controller/src/lib/controller/user/controllerAddUser/controllerCallAddUser.ts
@@ -33,5 +33,4 @@ export async function controllerCallAddUser(session: Session, user: SendUser): P
     const data = (await commonControllerCall("/api/settings/user/addUser", session, user) as User | null);
 
     return data;
-
 }
diff --git a/...ta-access-controller/src/lib/controller/user/controllerAddUser/controllerDecodeAddUser.ts b/...ta-access-controller/src/lib/controller/user/controllerAddUser/controllerDecodeAddUser.ts
@@ -108,7 +108,6 @@ export async function controllerDecodeAddUser(
         await commonControllerDecode(() => controllerCallAddUser(session, addUserEncode), false) as User | boolean);
 
     return res;
-
 }
 
 export default { InviteConst, controllerDecodeAddUser };
diff --git a/...-access-controller/src/lib/controller/user/controllerEditUser/controllerDecodeEditUser.ts b/...-access-controller/src/lib/controller/user/controllerEditUser/controllerDecodeEditUser.ts
@@ -64,7 +64,6 @@ export async function controllerDecodeEditUser(
         await commonControllerDecode(() => controllerCallEditUser(session, id, editUserEncode), false) as User | null);
 
     return usersData;
-
 }
 
 export default controllerDecodeEditUser;
diff --git a/...access-controller/src/lib/controller/user/controllerViewUser/controllerDecodeViewUsers.ts b/...access-controller/src/lib/controller/user/controllerViewUser/controllerDecodeViewUsers.ts
@@ -52,7 +52,6 @@ export async function controllerDecodeViewUsers(session: Session): Promise<Inter
     }
 
     return usersData;
-
 }
 
 export default controllerDecodeViewUsers;
diff --git a/...ness-app/data-access/data-access-common-api-util/src/lib/apiUtil/api/apiRequestOptions.ts b/...ness-app/data-access/data-access-common-api-util/src/lib/apiUtil/api/apiRequestOptions.ts
@@ -28,10 +28,12 @@ import { Session } from "next-auth";
  * @returns header object that can used for IS API calls.
  */
 export function requestOptions(session: Session): RequestInit {
+
     return apiRequestOptions(session, getHostedUrl());
 }
 
 export function requestOptionsWithBody(session: Session, method: string, body: BodyInit): RequestInit {
+
     return apiRequestOptionsWithBody(session, method, body, getHostedUrl());
 }
 

diff --git a/...pp/data-access/data-access-controller/src/lib/controller/controllerMe/controllerCallMe.ts b/...pp/data-access/data-access-controller/src/lib/controller/controllerMe/controllerCallMe.ts
@@ -32,5 +32,4 @@ export async function controllerCallMe(session: Session): Promise<InternalUser |
     const data = ( await commonControllerCall("/api/dashboard/me", session) as InternalUser | null);
 
     return data;
-
 }
diff --git a/.../data-access/data-access-controller/src/lib/controller/controllerMe/controllerDecodeMe.ts b/.../data-access/data-access-controller/src/lib/controller/controllerMe/controllerDecodeMe.ts
@@ -44,7 +44,6 @@ export async function controllerDecodeMe(session: Session) : Promise<InternalUse
     } 
 
     return null;
-
 }
 
 export default controllerDecodeMe;
diff --git a/...ata-access-controller/src/lib/controller/controllerSwitchOrg/controllerDecodeSwitchOrg.ts b/...ata-access-controller/src/lib/controller/controllerSwitchOrg/controllerDecodeSwitchOrg.ts
@@ -39,7 +39,6 @@ function getOrgId(token: JWT): string {
 
         return config.CommonConfig.ApplicationConfig.SampleOrganization[0].id;
     }
-
 }
 
 /**
@@ -57,7 +56,6 @@ export async function controllerDecodeSwitchOrg(token: JWT): Promise<OrgSession
         await commonControllerDecode(() => controllerCallSwitchOrg(subOrgId, accessToken), null) as OrgSession | null);
 
     return res;
-
 }
 
 export default controllerDecodeSwitchOrg;
diff --git a/...le/libs/shared/data-access/data-access-common-models-util/src/lib/model/user/userUtils.ts b/...le/libs/shared/data-access/data-access-common-models-util/src/lib/model/user/userUtils.ts
@@ -59,8 +59,10 @@ export function setEmail(email: string) {
  */
 export function setUsername(userName: string) {
     if (config.BusinessAppConfig.ManagementAPIConfig.UserStore.trim()===""){
+
         return userName;
     } else {
+
         return `${config.BusinessAppConfig.ManagementAPIConfig.UserStore}/${userName}`;
     }
 }

diff --git a/...ample/libs/shared/ui/ui-components/src/lib/components/footerComponent/footerComponent.tsx b/...ample/libs/shared/ui/ui-components/src/lib/components/footerComponent/footerComponent.tsx
@@ -20,6 +20,7 @@ import React from "react";
 import styles from "./footerComponent.module.css";
 
 export function FooterComponent() {
+
     return (
         <footer className={ styles["footer"] }>
             <a

diff --git a/...ple/libs/shared/ui/ui-components/src/lib/components/sidenavComponent/sidenavComponent.tsx b/...ple/libs/shared/ui/ui-components/src/lib/components/sidenavComponent/sidenavComponent.tsx
@@ -18,7 +18,7 @@
 
 import { SideNavItem, SideNavList } from "@b2bsample/shared/data-access/data-access-common-models-util";
 import { getIconFromString, hideBasedOnScopes } from "@b2bsample/shared/util/util-front-end-util";
-import { Button, FlexboxGrid, Nav, Sidenav, Stack, Tag } from "rsuite";
+import { Button, Nav, Sidenav, Stack, Tag } from "rsuite";
 import "rsuite/dist/rsuite.min.css";
 import styles from "./sidenavComponent.module.css";
 import { SidenavComponentProps } from "../../models/sidenavComponent/sidenavComponent";
@@ -44,6 +44,7 @@ export function SidenavComponent(prop: SidenavComponentProps) {
                             sideNavConfigList.items.map((item: SideNavItem) => {
 
                                 if (item.items) {
+
                                     return (
                                         <Nav.Menu
                                             eventKey={ item.eventKey }
@@ -61,7 +62,8 @@ export function SidenavComponent(prop: SidenavComponentProps) {
                                                         onSelect={ (eventKey) =>
                                                             activeKeySideNavSelect(eventKey) }
                                                         style={ item.hideBasedOnScope
-                                                            ? hideBasedOnScopes(scope, item.type, item.items, item.scopes)
+                                                            ? hideBasedOnScopes(
+                                                                scope, item.type, item.items, item.scopes)
                                                             : {} }>
                                                         <Stack spacing={ 10 }>
                                                             { item.title }
@@ -75,6 +77,7 @@ export function SidenavComponent(prop: SidenavComponentProps) {
                                         </Nav.Menu>
                                     );
                                 } else {
+
                                     return (
                                         <Nav.Item
                                             key={ item.eventKey }
-Original file line number
+Diff line change
@@ Expand Up @@
         };
         const onIdpCreated = (response: IdentityProvider): void => {
             if (response) {
                 successTypeDialog(toaster, "Success", "Identity Provider is created successfully");
@@ Expand Down @@
Original file line number	Diff line number	Diff line change
Expand Up		@@ -33,5 +33,4 @@ export async function controllerCallAddUser(session: Session, user: SendUser): P
		const data = (await commonControllerCall("/api/settings/user/addUser", session, user) as User \| null);

		return data;

		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -32,5 +32,4 @@ export async function controllerCallMe(session: Session): Promise<InternalUser \|
		const data = ( await commonControllerCall("/api/dashboard/me", session) as InternalUser \| null);

		return data;

		}