Fix/program client custom types #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukacan
force-pushed
the
fix/program_client-custom-types
branch
2 times, most recently
from
1efa8e4 to
00e1e89
Compare
Ikrk
suggested changes
Feb 14, 2024
crates/client/src/idl.rs
Outdated
| } | ||
|
|
||
| fn find_item_path(code: &str, target_item_name: &str) -> Option<String> { | ||
| let syn_file = syn::parse_file(code).ok()?; |
There was a problem hiding this comment.
I think it is not necessary to call the expensive parse_file function all over again every time the find_item_path is called. It would be better to pass it as a reference to the parsed file that is parsed at the beginning of the parse_to_idl_program function and therefore do the parsing only once...
Ikrk
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
I have corrected a problem when a program has a hyphen "-" in its name. This resulted into "unexpected token" error. Converting the name to snake case fixed the issue.
Also, it would be nice to get rid of the unnecessary cloning in the future, but this could be done in a separate PR.
…ypes are private and cannot be used within program_client
Ikrk
force-pushed
the
fix/program_client-custom-types
branch
from
a615c4b to
19a56da
Compare
Ikrk
added a commit
that referenced
this pull request
Feb 15, 2024
* obtain full path for custom types (Struct/Enum), provide good UX if types are private and cannot be used within program_client * ✅ add cargo test for program_client * 🔥 removed duplicate code * 🐛 Fixed malformed program name. --------- Co-authored-by: lukacan <[email protected]> Co-authored-by: Ikrk <[email protected]>
lukacan
added a commit
that referenced
this pull request
May 20, 2024
* obtain full path for custom types (Struct/Enum), provide good UX if types are private and cannot be used within program_client * ✅ add cargo test for program_client * 🔥 removed duplicate code * 🐛 Fixed malformed program name. --------- Co-authored-by: lukacan <[email protected]> Co-authored-by: Ikrk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update parse_to_idl_program so that it can obtain the full path for custom types. The implemented function will warn the user if the path is private and cannot be imported.
This is out of scope, but I found it useful to update the examples.
Added some custom types into the cargo test expected/expanded code so that the functionality can be tested.