fix/warn user on composite accounts and continue fuzz test generation #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikrk
force-pushed
the
fix/warn-on-composite-accounts
branch
from
62ca205 to
86aaa3f
Compare
lukacan
reviewed
Mar 1, 2024
There was a problem hiding this comment.
It looks nice, for the fuzz tests, however for the PoC Tests there is a problem within the .program_client, where the path to the composite account is not correctly derived. I would suggest that this can be fixed with including pub module accounts derived by anchor. However, from my side, this can be resolved as a different fix.
|
Yes, I am aware of it. I have already created a new bug issue in Jira. |
lukacan
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the user gets notified in case the anchor program uses currently unsupported composite accounts. Now the fuzz test generation is not aborted but continues and the composite account deserialization code is replaced with a
todo!()macro.A warning example:
Warning: The context `Initialize` has a field named `comp_acc` of composite type `LiqPoolInitialize < 'info >`. The automatic deserialization of composite types is currently not supported. You will have to implement it manually in the generated `accounts_snapshots.rs` file. The field deserialization was replaced by a `todo!()` macro. Also, you might want to adapt the corresponding FuzzInstruction variants in `fuzz_instructions.rs` file.