Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDVT DATENAME and DATEPART fixes with SOW = monday for II-12238 and II-12239 #36

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

hab6
Copy link
Collaborator

@hab6 hab6 commented Sep 20, 2023

Summary

Remedy for failures that occur in TDVT test cases datename.sow.week and datepart.sow.week with sow='monday' using the Actian JDBC Connector. A couple other minor formatting issues were also fixed.

Affected TDVT Test Cases

JIra Issue Test Name Test Case
II-12238 date.datename.sow.week DATENAME('week', [date2], 'monday')
DATENAME('week', [datetime0], 'monday')
II-12239 date.datepart.sow.week DATEPART('week', [date2], 'monday')
DATEPART('week', [datetime0], 'monday')

Important Note: The test cases involving field date2 are not yet passing due to Connector SDK issue #1182. If the Tableau Connector SDK team agrees to update the expected files, this should allow the two date2 tests to pass.

TDVT Results

Note Passed Failed Total
Before Fix 837 31 868
After Fix 839 29 868

Test Results

test_results_combined-BEFOREFIXES.csv
test_results_combined-AFTERFIXES.csv

@hab6 hab6 requested a review from clach04 September 20, 2023 19:55
Copy link
Member

@clach04 clach04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great! Nice to see some explanation doc comments

@clach04 clach04 merged commit 1663808 into master Sep 20, 2023
@hab6 hab6 deleted the hab6-fix-datenamepart branch September 20, 2023 20:17
@hab6
Copy link
Collaborator Author

hab6 commented Oct 10, 2023

Additional information about this issue:

The fix is correct, but for the DATENAME and DATEPART tests cases involving the date2 column, the corresponding TDVT canon files are incorrect. See issue 2 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants