Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo needs review in comment in README #34

Closed
clach04 opened this issue Feb 23, 2024 · 1 comment
Closed

typo needs review in comment in README #34

clach04 opened this issue Feb 23, 2024 · 1 comment

Comments

@clach04
Copy link
Member

clach04 commented Feb 23, 2024

See https://github.com/ActianCorp/sqlalchemy-ingres/blob/master/README.md?plain=1#L165

This is not valid code if uncommented. Options:

  1. change to #import sqlalchemy_ingres or import sqlalchemy_ingres
  2. Remove.

@hab6 thoughts?
hab6 added a commit that referenced this issue Mar 12, 2024
@hab6
Minor updates to python code example #34
c7bd538
@hab6
Copy link
Contributor

hab6 commented Mar 12, 2024

Completed via PR #38

@hab6 hab6 closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clach04 @hab6